Re: [PATCH 2/2] progress: remove redundant null-checking
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- Jul 10, 2020, 23:03 UTC
- Message-ID
- <20200710230334.GH3189386@google.com>
- In-Reply-To
- <20200710202955.GF3189386@google.com>
On Fri, Jul 10, 2020 at 01:29:55PM -0700, Emily Shaffer wrote:
Show 18 quoted lines
> > On Fri, Jul 10, 2020 at 12:58:54PM -0700, Junio C Hamano wrote: > > > > Emily Shaffer <emilyshaffer@google.com> writes: > > > > > Will it make your life easier if I base this series on the other topic? > > > Or would you rather I leave it to you? > > > > Either is fine. > > > > Just don't expect any quick turnaround time for a new and involved > > change like this while we are entering the pre-release freeze. We > > are supposed to be stablizing, not churning ;-). > > Understood. > > It's got a nit or two from Stolee's review so I need to reroll it > anyway; I'll send it based on the other topic.
Hum. It seems that, as of `git fetch github.com/gitster/git` in the past hour, sg/commit-graph-progress-fix doesn't include es/trace-log-progress, so I don't think it is actually a good idea for me to submit this series based on sg/commit-graph-progress-fix instead. I'll send the next version based on master, after all.
> > - Emily