Re: [PATCH] run-command: document use_shell option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 22, 2021, 22:21 UTC
- Message-ID
- <xmqqzh1062as.fsf@gitster.c.googlers.com>
- In-Reply-To
- <YAs9pTBsdskC8CPN@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 18 quoted lines
> diff --git a/run-command.h b/run-command.h
> index 6472b38bde..d08414a92e 100644
> --- a/run-command.h
> +++ b/run-command.h
> @@ -126,8 +126,15 @@ struct child_process {
> */
> unsigned silent_exec_failure:1;
>
> - unsigned stdout_to_stderr:1;
> + /**
> + * Run the command from argv[0] using a shell (but note that we may
> + * still optimize out the shell call if the command contains no
> + * metacharacters). Note that further arguments to the command in
> + * argv[1], etc, do not need to be shell-quoted.
> + */
> unsigned use_shell:1;
> +
> + unsigned stdout_to_stderr:1;Reads well. Thanks.
It is curious why "diff" chose to move stdout_to_stderr line around, though.
> unsigned clean_on_exit:1; > unsigned wait_after_clean:1; > void (*clean_on_exit_handler)(struct child_process *process);