Re: [PATCH v2] upload-pack.c: fix filter spec quoting bug
- From
Jeff King <peff@peff.net>
- Date
- Jan 25, 2021, 21:16 UTC
- Message-ID
- <YA81EwddIG7QVI/1@coredump.intra.peff.net>
- In-Reply-To
- <20210125170921.14291-1-jacob@gitlab.com>
On Mon, Jan 25, 2021 at 06:09:21PM +0100, Jacob Vosmaer wrote:
> +test_expect_success 'hook works with partial clone' ' > + clear_hook_results && > + test_config_global uploadpack.packObjectsHook ./hook && > + test_config_global uploadpack.allowFilter true &&
I was going to complain that:
test_config -C dst.git uploadpack.packObjectsHook ./hook && test_config -C dst.git uploadpack.allowFilter true &&
would be more clear, since it tells us which repo we care about impacting. But the rest of the script doesn't do that, and indeed it can't, because we don't allow packObjectsHook to be set in per-repo config for security reasons. :)
(We could do it per-repo for allowFilter, but I think it is just as well to keep the two calls consistent).
> + git clone --bare --no-local --filter=blob:none . dst.git && > + git -C dst.git rev-list --objects --missing=print HEAD >objects && > + grep "^?" objects
Previously that clone would fail, so the bug-fix is demonstrated by it succeeding. But the other two commands are added to make sure that we actually did apply the filter correctly. Even better. Thanks for being thorough.
-Peff