Re: [PATCH 0/9] remove dead shell code

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 2, 2021, 20:56 UTC
Message-ID: <xmqqzgsuitmt.fsf@gitster.g>
In-Reply-To: <CAJm9OHfN9iXDt-rzu-wb=67y4PPpmCUgMfmZPy1JMBJkHG256g@mail.gmail.com>

Peter Baumann <peter.baumann@gmail.com> writes:

Show 15 quoted lines

> Hm, I have scripts here, implementing some porcelain commands which
> follow the same approach as
> the git porcelain scripts, e.g.
>
>   #!/bin/bash
>   SUBDIRECTORY_OK=Yes
>   . git-sh-setup
>   require_work_tree
>   require_clean_work_tree
>   cd_to_toplevel || die "Can't find top level for the git repo"
>   set_reflog_action my-special-script                          # this
> will be broken by the patch series
>
> I was under the impression that this is how it should be done when one
> needs to write some custom git scripts.

The reason why output from "git log --stat -- git-sh-setup.sh" does not have that much removal is exactly this. These are part of our published API. It is very much appreciated that you raised this point.

Thanks.