git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/9] git-sh-setup: remove unused sane_egrep() function

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Sep 2, 2021, 16:01 UTC
Message-ID
<patch-4.9-73f0676db7a-20210902T155758Z-avarab@gmail.com>
In-Reply-To
<cover-0.9-00000000000-20210902T155758Z-avarab@gmail.com>

The is_zero_oid() function in git-submodule.sh has not been used since e83e3333b57 (submodule: port submodule subcommand 'summary' from shell to C, 2020-08-13), so we can remove it, and the sane_egrep() function, dead is_zero_oid() was the only function which still referenced it.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 git-sh-setup.sh  | 4 ----
 git-submodule.sh | 5 -----
 2 files changed, 9 deletions(-)
diff --git a/git-sh-setup.sh b/git-sh-setup.sh
index d4e8225affa..a2a28982b6d 100644
--- a/git-sh-setup.sh
+++ b/git-sh-setup.sh
@@ -110,10 +110,6 @@ sane_grep () {
 	GREP_OPTIONS= LC_ALL=C grep @@SANE_TEXT_GREP@@ "$@"
 }
 
-sane_egrep () {
-	GREP_OPTIONS= LC_ALL=C egrep @@SANE_TEXT_GREP@@ "$@"
-}
-
 is_bare_repository () {
 	git rev-parse --is-bare-repository
 }
diff --git a/git-submodule.sh b/git-submodule.sh
index dbd2ec20503..aeb96c58243 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -63,11 +63,6 @@ isnumber()
 	n=$(($1 + 0)) 2>/dev/null && test "$n" = "$1"
 }
 
-# Given a full hex object ID, is this the zero OID?
-is_zero_oid () {
-	echo "$1" | sane_egrep '^0+$' >/dev/null 2>&1
-}
-
 # Sanitize the local git environment for use within a submodule. We
 # can't simply use clear_local_git_env since we want to preserve some
 # of the settings from GIT_CONFIG_PARAMETERS.
-- 
2.33.0.814.gb82868f05f3
Previous: Andrei RybakNext: Ævar Arnfjörð Bjarmason
Message 7 of 39 in “remove dead shell code”
  1. 0/9 remove dead shell codeÆvar Arnfjörð Bjarmason, Sep 2, 2021
  2. 1/9 git-sh-setup: remove unused set_reflog_action() functionÆvar Arnfjörð Bjarmason, Sep 2, 2021
  3. 2/9 git-sh-setup: remove unused git_editor() functionÆvar Arnfjörð Bjarmason, Sep 2, 2021
  4. 3/9 git-sh-setup: remove unused git_pager() functionÆvar Arnfjörð Bjarmason, Sep 2, 2021
  5. Philippe BlainSep 2, 2021
  6. Andrei RybakSep 2, 2021
  7. 4/9 git-sh-setup: remove unused sane_egrep() functionÆvar Arnfjörð Bjarmason, Sep 2, 2021
  8. 5/9 git-sh-setup: remove unused require_work_tree_exists() functionÆvar Arnfjörð Bjarmason, Sep 2, 2021
  9. 6/9 git-sh-setup: move create_virtual_base() to mergetools/p4mergeÆvar Arnfjörð Bjarmason, Sep 2, 2021
  10. 7/9 git-sh-setup: move peel_committish() function to git-subtree.shÆvar Arnfjörð Bjarmason, Sep 2, 2021
  11. 8/9 git-bisect: remove unused SHA-1 $x40 shell variableÆvar Arnfjörð Bjarmason, Sep 2, 2021
  12. 9/9 test-lib: remove unused $_x40 and $_z40 variablesÆvar Arnfjörð Bjarmason, Sep 2, 2021
  13. Peter BaumannSep 2, 2021
  14. Junio C HamanoSep 2, 2021
  15. Junio C HamanoSep 2, 2021
  16. Carlo ArenasSep 2, 2021
  17. Junio C HamanoSep 2, 2021
  18. Ævar Arnfjörð BjarmasonSep 2, 2021
  19. Junio C HamanoSep 2, 2021
  20. 0/7 remove dead & undocumented shell codeÆvar Arnfjörð Bjarmason, Sep 6, 2021
  21. 2/7 git-sh-setup: remove unused sane_egrep() functionÆvar Arnfjörð Bjarmason, Sep 6, 2021
  22. 3/7 git-sh-setup: move peel_committish() function to git-subtree.shÆvar Arnfjörð Bjarmason, Sep 6, 2021
  23. 1/7 git-sh-setup: remove unused git_pager() functionÆvar Arnfjörð Bjarmason, Sep 6, 2021
  24. Phillip WoodSep 6, 2021
  25. Ævar Arnfjörð BjarmasonSep 6, 2021
  26. Phillip WoodSep 7, 2021
  27. Ævar Arnfjörð BjarmasonSep 7, 2021
  28. Junio C HamanoSep 7, 2021
  29. Ævar Arnfjörð BjarmasonSep 7, 2021
  30. 5/7 git-sh-setup: remove unused "pull with rebase" messageÆvar Arnfjörð Bjarmason, Sep 6, 2021
  31. 4/7 git-sh-setup: clear_local_git_env() function to git-submodule.shÆvar Arnfjörð Bjarmason, Sep 6, 2021
  32. 6/7 git-bisect: remove unused SHA-1 $x40 shell variableÆvar Arnfjörð Bjarmason, Sep 6, 2021
  33. 7/7 test-lib: remove unused $_x40 and $_z40 variablesÆvar Arnfjörð Bjarmason, Sep 6, 2021
  34. 0/4 remove dead & internal-only shell codeÆvar Arnfjörð Bjarmason, Sep 11, 2021
  35. 2/4 git-sh-setup: remove unused "pull with rebase" messageÆvar Arnfjörð Bjarmason, Sep 11, 2021
  36. 1/4 git-submodule: remove unused is_zero_oid() functionÆvar Arnfjörð Bjarmason, Sep 11, 2021
  37. Junio C HamanoSep 13, 2021
  38. 3/4 git-bisect: remove unused SHA-1 $x40 shell variableÆvar Arnfjörð Bjarmason, Sep 11, 2021
  39. 4/4 test-lib: remove unused $_x40 and $_z40 variablesÆvar Arnfjörð Bjarmason, Sep 11, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.