Re: [PATCH 3/7] simple-ipc: move definition of ipc_active_state outside of ifdef

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 20, 2021, 15:51 UTC
Message-ID: <xmqqzgs7ckjc.fsf@gitster.g>
In-Reply-To: <93ebf97b-1282-8f39-6894-90e0ea2dc851@jeffhostetler.com>

Jeff Hostetler <git@jeffhostetler.com> writes:

Show 19 quoted lines

> On 9/15/21 5:06 PM, Junio C Hamano wrote:
>> "Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes:
>> 
>>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>>
>>> From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
>>>
>>> Move the declartion of the `enum ipc_active_state` type outside of
>>> the SUPPORTS_SIMPLE_IPC ifdef.
>> The second one is not an in-body header since there is already a
>> blank line that signals the end of in-body headers after the first
>> one.
>> This _may_ be a bug in GGG, perhaps?
>
> Maybe.  I'll make a note to ask @dscho when he gets back from vacation.
>
> Credit for the commit should go to Carlo.  I just added it to the series
> with his "From:" line and it looks like GGG added an extra one before
> it.

Thanks for a clarification.  I'll tweak the authorship when queuing.