Re: [PATCH 7/7] t/helper/simple-ipc: convert test-simple-ipc to use start_bg_command
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Sep 16, 2021, 05:55 UTC
- Message-ID
- <87v931gj1s.fsf@evledraar.gmail.com>
- In-Reply-To
- <57f29feaadb4a732892cd193b2a1d3c838f09421.1631738177.git.gitgitgadget@gmail.com>
On Wed, Sep 15 2021, Jeff Hostetler via GitGitGadget wrote:
[...]
Show 25 quoted lines
> + default:
> + case SBGR_ERROR:
> + case SBGR_CB_ERROR:
> + return error("daemon failed to start");
>
> - /*
> - * We don't care about the WEXITSTATUS() nor
> - * any of the WIF*(status) values because
> - * `cmd__simple_ipc()` does the `!!result`
> - * trick on all function return values.
> - *
> - * So it is sufficient to just report the
> - * early shutdown as an error.
> - */
> - return error(_("daemon failed to start"));
> - }
> + case SBGR_TIMEOUT:
> + return error("daemon not online yet");
>
> - else
> - return error(_("waitpid is confused"));
> + case SBGR_DIED:
> + return error("daemon terminated");
> }
> }It's not mentioned in the commit message, but the while-we're-at-it dropping of _() makes sense here, it shouldn't have been used in a test helper to begin with. I.e. translators don't need to be translating stuff purely internal to the test suite.