git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-parse: fix mismatch quoting of separator in the message

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 22, 2021, 19:28 UTC
Message-ID
<xmqqzgs45s15.fsf@gitster.g>
In-Reply-To
<YUtqp+1Mwl2v0kuh@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 8 quoted lines
> On Wed, Sep 22, 2021 at 06:17:45PM +0700, Bagas Sanjaya wrote:
>> There is a quoting mismatch quoting `--` separator in "no usage string
>> given...." message (`' instead of ``). Fix it.
>
> For what it's worth, I think that the `' style is typographic, since the
> pair look like English "smart quotes" (as opposed to straight quotes). I
> have no opinion about which is better, but I don't think the pre-image
> was necessarily a mistake.
I thought that we try to avoid "smart quotes" in our messages.

And we do not expect our users to be expecting to read their error messages in markdown, so `--` is not a "Fix", either (do we have many instances of such uses of backticks in messages already?).

Let's just stick to the true and tried pair of single quotes here.
Thanks.
Previous: Taylor BlauNext: Taylor Blau
Message 3 of 7 in “rev-parse: fix mismatch quoting of separator in the message”
  1. rev-parse: fix mismatch quoting of separator in the messageBagas Sanjaya, Sep 22, 2021
  2. Taylor BlauSep 22, 2021
  3. Junio C HamanoSep 22, 2021
  4. Taylor BlauSep 22, 2021
  5. Ævar Arnfjörð BjarmasonSep 22, 2021
  6. Taylor BlauSep 22, 2021
  7. Junio C HamanoSep 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.