git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-parse: fix mismatch quoting of separator in the message

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 22, 2021, 20:58 UTC
Message-ID
<xmqqfstw5nv2.fsf@gitster.g>
In-Reply-To
<YUuNOcqClVjQamYh@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 11 quoted lines
> I agree. But for what it's worth, I think we should:
>
>   - accept patches, such as this one, which move things in a positive
>     direction
>
>   - not spend a ton of time or reviewer bandwidth on conversions
>     throughout the tree
>
> In other words, I'm happy to see patches like this, or little clean-ups
> along the way in related areas, but I would be unhappy to see a massive
> patch to change all instances from one to the other.

Oh, absolutely. But let's not accept a small patch that swaps one bad style `--' to another bad one `--`, which does not improve anything.

Previous: Taylor Blau
Message 7 of 7 in “rev-parse: fix mismatch quoting of separator in the message”
  1. rev-parse: fix mismatch quoting of separator in the messageBagas Sanjaya, Sep 22, 2021
  2. Taylor BlauSep 22, 2021
  3. Junio C HamanoSep 22, 2021
  4. Taylor BlauSep 22, 2021
  5. Ævar Arnfjörð BjarmasonSep 22, 2021
  6. Taylor BlauSep 22, 2021
  7. Junio C HamanoSep 22, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.