git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] gitk: set log.graph=false when running `git log`

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 9, 2022, 18:26 UTC
Message-ID
<xmqqzgmz7v6k.fsf@gitster.g>
In-Reply-To
<20220209162350.169971-3-alexhenrie24@gmail.com>
Alex Henrie <alexhenrie24@gmail.com> writes:
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  gitk-git/gitk | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

This may handle "gitk", but what about thousands other scripts people have developed around "git log", I have to wonder.

Show 28 quoted lines
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 23d9dd1fe0..1d8a5ff622 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -411,8 +411,9 @@ proc start_rev_list {view} {
>      }
>  
>      if {[catch {
> -        set fd [open [concat | git log --no-color -z --pretty=raw $show_notes \
> -                        --parents --boundary $args "--" $files] r]
> +        set fd [open [concat | git -c log.graph=false log --no-color -z \
> +                        --pretty=raw $show_notes --parents --boundary $args \
> +                        "--" $files] r]
>      } err]} {
>          error_popup "[mc "Error executing git log:"] $err"
>          return 0
> @@ -559,8 +560,9 @@ proc updatecommits {} {
>          set args $vorigargs($view)
>      }
>      if {[catch {
> -        set fd [open [concat | git log --no-color -z --pretty=raw $show_notes \
> -                        --parents --boundary $args "--" $vfilelimit($view)] r]
> +        set fd [open [concat | git -c log.graph=false log --no-color -z \
> +                        --pretty=raw $show_notes --parents --boundary $args \
> +                        "--" $vfilelimit($view)] r]
>      } err]} {
>          error_popup "[mc "Error executing git log:"] $err"
>          return
Previous: Alex HenrieNext: Alex Henrie
Message 6 of 9 in “log: fix memory leak if --graph is passed multiple times”
  1. 1/3 log: fix memory leak if --graph is passed multiple timesAlex Henrie, Feb 9, 2022
  2. 2/3 log: add a config option for --graphAlex Henrie, Feb 9, 2022
  3. Junio C HamanoFeb 9, 2022
  4. Alex HenrieFeb 10, 2022
  5. 3/3 gitk: set log.graph=false when running `git log`Alex Henrie, Feb 9, 2022
  6. Junio C HamanoFeb 9, 2022
  7. Alex HenrieFeb 10, 2022
  8. Junio C HamanoFeb 10, 2022
  9. Junio C HamanoFeb 9, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.