From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 09 Feb 2022 18:26:43 GMT
Subject: Re: [PATCH 3/3] gitk: set log.graph=false when running `git log`
Message-ID: <xmqqzgmz7v6k.fsf@gitster.g>
In-Reply-To: <20220209162350.169971-3-alexhenrie24@gmail.com>

Alex Henrie <alexhenrie24@gmail.com> writes:

> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  gitk-git/gitk | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

This may handle "gitk", but what about thousands other scripts
people have developed around "git log", I have to wonder.



> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 23d9dd1fe0..1d8a5ff622 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -411,8 +411,9 @@ proc start_rev_list {view} {
>      }
>  
>      if {[catch {
> -        set fd [open [concat | git log --no-color -z --pretty=raw $show_notes \
> -                        --parents --boundary $args "--" $files] r]
> +        set fd [open [concat | git -c log.graph=false log --no-color -z \
> +                        --pretty=raw $show_notes --parents --boundary $args \
> +                        "--" $files] r]
>      } err]} {
>          error_popup "[mc "Error executing git log:"] $err"
>          return 0
> @@ -559,8 +560,9 @@ proc updatecommits {} {
>          set args $vorigargs($view)
>      }
>      if {[catch {
> -        set fd [open [concat | git log --no-color -z --pretty=raw $show_notes \
> -                        --parents --boundary $args "--" $vfilelimit($view)] r]
> +        set fd [open [concat | git -c log.graph=false log --no-color -z \
> +                        --pretty=raw $show_notes --parents --boundary $args \
> +                        "--" $vfilelimit($view)] r]
>      } err]} {
>          error_popup "[mc "Error executing git log:"] $err"
>          return