Re: [PATCH v4 0/8] t7004: Modernize the style

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 6, 2024, 00:45 UTC
Message-ID: <xmqqzfpqzdgk.fsf@gitster.g>
In-Reply-To: <20240805235917.190699-1-abdobngad@gmail.com>

AbdAlRahman Gad <abdobngad@gmail.com> writes:

Show 9 quoted lines

> AbdAlRahman Gad (8):
>   [Newcomer] t7004: Remove space after redirect operators
>   [Newcomer] t7004: Do not lose exit status to pipe
>   [Newcomer] t7004: One command per line
>   [Newcomer] t7004: Do not prepare things outside test_expect_success
>   [Newcomer] t7004: Use indented here-doc
>   [Newcomer] t7004: Description on the same line as test_expect_success
>   [Newcomer] t7004: Description and test body seperated with backslash
>   [Newcomer] t7004: Use single quotes instead of double quotes

As you can see from "git shortlog --no-merges --since=6.months", we do not capitalize the first word of the title description of each patch.

Also, I haven't looked at the individual patches, it seems the patch is somewhoat whitespace damaged.

    $ git am -s ./+ag8-v4
    Applying: t7004: remove space after redirect operators
    .git/rebase-apply/patch:169: indent with spaces.
            git checkout stable &&
    .git/rebase-apply/patch:193: indent with spaces.
            git tag v4.0
    warning: 2 lines add whitespace errors.
    Applying: t7004: do not lose exit status to pipe
    Applying: t7004: one command per line
    Applying: t7004: do not prepare things outside test_expect_success
    .git/rebase-apply/patch:1188: indent with spaces.
            git tag v4.0
    warning: 1 line adds whitespace errors.
    Applying: t7004: use indented here-doc
    Applying: t7004: description on the same line as test_expect_success
    Applying: t7004: test description and test body seperated with backslash
    Applying: t7004: use single quotes instead of double quotes
    .git/rebase-apply/patch:133: indent with spaces.
            git tag v4.0
    warning: 1 line adds whitespace errors.