git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/8] t7004: Modernize the style

From
AbdAlRahman Gad <abdobngad@gmail.com>
Date
Aug 6, 2024, 08:44 UTC
Message-ID
<749fcee3-5bb1-49ff-b476-6bb75f4b92f8@gmail.com>
In-Reply-To
<xmqqzfpqzdgk.fsf@gitster.g>
On 8/6/24 03:45, Junio C Hamano wrote:
Show 40 quoted lines
> AbdAlRahman Gad <abdobngad@gmail.com> writes:
> 
>> AbdAlRahman Gad (8):
>>    [Newcomer] t7004: Remove space after redirect operators
>>    [Newcomer] t7004: Do not lose exit status to pipe
>>    [Newcomer] t7004: One command per line
>>    [Newcomer] t7004: Do not prepare things outside test_expect_success
>>    [Newcomer] t7004: Use indented here-doc
>>    [Newcomer] t7004: Description on the same line as test_expect_success
>>    [Newcomer] t7004: Description and test body seperated with backslash
>>    [Newcomer] t7004: Use single quotes instead of double quotes
> 
> As you can see from "git shortlog --no-merges --since=6.months", we
> do not capitalize the first word of the title description of each
> patch.
> 
> Also, I haven't looked at the individual patches, it seems the patch
> is somewhoat whitespace damaged.
> 
>      $ git am -s ./+ag8-v4
>      Applying: t7004: remove space after redirect operators
>      .git/rebase-apply/patch:169: indent with spaces.
>              git checkout stable &&
>      .git/rebase-apply/patch:193: indent with spaces.
>              git tag v4.0
>      warning: 2 lines add whitespace errors.
>      Applying: t7004: do not lose exit status to pipe
>      Applying: t7004: one command per line
>      Applying: t7004: do not prepare things outside test_expect_success
>      .git/rebase-apply/patch:1188: indent with spaces.
>              git tag v4.0
>      warning: 1 line adds whitespace errors.
>      Applying: t7004: use indented here-doc
>      Applying: t7004: description on the same line as test_expect_success
>      Applying: t7004: test description and test body seperated with backslash
>      Applying: t7004: use single quotes instead of double quotes
>      .git/rebase-apply/patch:133: indent with spaces.
>              git tag v4.0
>      warning: 1 line adds whitespace errors.
> 
Thanks! I'll fix that and send a v5.
Previous: Junio C Hamano
Message 21 of 21 in “t7004: Modernize the style”
  1. 0/8 t7004: Modernize the styleAbdAlRahman Gad, Aug 5, 2024
  2. 1/8 [Newcomer] t7004: Remove space after redirect operatorsAbdAlRahman Gad, Aug 5, 2024
  3. 2/8 [Newcomer] t7004: Do not lose exit status to pipeAbdAlRahman Gad, Aug 5, 2024
  4. Eric SunshineAug 6, 2024
  5. AbdAlRahman GadAug 6, 2024
  6. Eric SunshineAug 6, 2024
  7. 3/8 [Newcomer] t7004: One command per lineAbdAlRahman Gad, Aug 5, 2024
  8. 4/8 [Newcomer] t7004: Do not prepare things outside test_expect_successAbdAlRahman Gad, Aug 5, 2024
  9. Eric SunshineAug 6, 2024
  10. AbdAlRahman GadAug 6, 2024
  11. 5/8 [Newcomer] t7004: Use indented here-docAbdAlRahman Gad, Aug 5, 2024
  12. 6/8 [Newcomer] t7004: Description on the same line as test_expect_successAbdAlRahman Gad, Aug 5, 2024
  13. 7/8 [Newcomer] t7004: test Description and test body seperated with backslashAbdAlRahman Gad, Aug 5, 2024
  14. 8/8 [Newcomer] t7004: Use single quotes instead of double quotesAbdAlRahman Gad, Aug 5, 2024
  15. Eric SunshineAug 6, 2024
  16. AbdAlRahman GadAug 6, 2024
  17. Eric SunshineAug 6, 2024
  18. Junio C HamanoAug 6, 2024
  19. Eric SunshineAug 6, 2024
  20. Junio C HamanoAug 6, 2024
  21. AbdAlRahman GadAug 6, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.