Re: [PATCH v2] git-svn: mention `svn:global-ignores` in help+docs

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 13, 2024, 22:33 UTC
Message-ID: <xmqqzfpg2gup.fsf@gitster.g>
In-Reply-To: <pull.1766.v2.git.git.1723578946962.gitgitgadget@gmail.com>

"Alex Galvin via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Alex Galvin <alex.v.galvin@gmail.com>
>
> Git-SVN was previously taught to use the svn:global-ignores attribute

I think the noun they use is not "attribute" but "property".

> as well as svn:ignore when creating or showing .gitignore files from a
> Subversion repository. However, the documentation and help message
> still only mentioned svn:ignore. This commit updates Git-SVN's

"This commit updates" -> "Update".

Show 10 quoted lines

> diff --git a/git-svn.perl b/git-svn.perl
> index a2a46608c9b..d8dc485e50d 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -219,11 +219,11 @@ my %cmd = (
>  	                "Set an SVN repository to a git tree-ish",
>  			{ 'stdin' => \$_stdin, %cmt_opts, %fc_opts, } ],
>  	'create-ignore' => [ \&cmd_create_ignore,
> -			     'Create a .gitignore per svn:ignore',
> +			     "Create a .gitignore per directory with an SVN ignore property",

Hmph. Is it intentional that this "create" side uses a single property while ...

Show 5 quoted lines

>  			     { 'revision|r=i' => \$_revision
>  			     } ],
>  	'mkdirs' => [ \&cmd_mkdirs ,
> -	              "recreate empty directories after a checkout",
> +	              "Recreate empty directories after a checkout",

Given that all other messages begin with capitalized verb, this is a good change for consistency, but it was not advertised in the proposed log message (just saying "While at it, capitalize the help message for 'mkdirs' command. for consistency" would be sufficient).

Show 9 quoted lines

>  	              { 'revision|r=i' => \$_revision } ],
>          'propget' => [ \&cmd_propget,
>  		       'Print the value of a property on a file or directory',
> @@ -234,7 +234,7 @@ my %cmd = (
>          'proplist' => [ \&cmd_proplist,
>  		       'List all properties of a file or directory',
>  		       { 'revision|r=i' => \$_revision } ],
> -	'show-ignore' => [ \&cmd_show_ignore, "Show svn:ignore listings",
> +	'show-ignore' => [ \&cmd_show_ignore, "Show .gitignore patterns from SVN ignore properties",

... the other "show" side talks about "ignore properties" (plural), implying that both svn:ignore and svn:global-ignores may get involved?

Show 5 quoted lines

>  			{ 'revision|r=i' => \$_revision
>  			} ],
>  	'show-externals' => [ \&cmd_show_externals, "Show svn:externals listings",
>
> base-commit: cabe67c0d1819fd1e33079e92615c6c7a3dc560d

Thanks.