Re: [PATCH v2] git-svn: mention `svn:global-ignores` in help+docs

From: Alex Galvin <agalvin@comqi.com>
Date: Aug 14, 2024, 17:53 UTC
Message-ID: <2edfbfad-bfae-4fe1-8f26-4310fc54b2a0@comqi.com>
In-Reply-To: <xmqqzfpg2gup.fsf@gitster.g>

On 2024-08-13 6:33 p.m., Junio C Hamano wrote:

Show 15 quoted lines

>> diff --git a/git-svn.perl b/git-svn.perl
>> index a2a46608c9b..d8dc485e50d 100755
>> --- a/git-svn.perl
>> +++ b/git-svn.perl
>> @@ -219,11 +219,11 @@ my %cmd = (
>>   	                "Set an SVN repository to a git tree-ish",
>>   			{ 'stdin' => \$_stdin, %cmt_opts, %fc_opts, } ],
>>   	'create-ignore' => [ \&cmd_create_ignore,
>> -			     'Create a .gitignore persvn:ignore',
>> +			     "Create a .gitignore per directory with an SVN ignore property",
> Hmph.  Is it intentional that this "create" side uses a single
> property while ...
> ... the other "show" side talks about "ignore properties" (plural),
> implying that both svn:ignore and svn:global-ignores may get
> involved?

I was trying to be precise that the create command makes one .gitignore file in each directory it visits, regardless if that directory only has one of the attributes or both. Would using "any SVN ignore property" instead of "a SVN ignore property" make this clear?

Thanks, Alex