Re: [PATCH 2/2] GIT-VERSION-GEN: fix overriding GIT_BUILT_FROM_COMMIT and GIT_DATE

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 19, 2024, 21:59 UTC
Message-ID: <xmqqzfkrgwps.fsf@gitster.g>
In-Reply-To: <CAO_smVhcai9reesTRSrd=hHz2Sa2T7Bs-U1NZ9KcCN5PNv6T5Q@mail.gmail.com>

Kyle Lippincott <spectral@google.com> writes:

Show 16 quoted lines

> On Thu, Dec 19, 2024 at 7:55 AM Patrick Steinhardt <ps@pks.im> wrote:
>>
>> Same as with the preceding commit, neither GIT_BUILT_FROM_COMMIT nor
>> GIT_DATE can be overridden via the environment. Especially the latter is
>> of importance given that we set it in our own "Documentation/doc-diff"
>> script.
>>
>> Make the values of both variables overridable.
>>
>> Signed-off-by: Patrick Steinhardt <ps@pks.im>
>> ---
>>  GIT-VERSION-GEN | 14 +++++++++++---
>>  1 file changed, 11 insertions(+), 3 deletions(-)
>
> Looks good, thanks for fixing this and for all the work done on the
> cleanups for the build system changes.

Thanks, all.