Re: [PATCH v2 0/5] GIT-VERSION-GEN: fix overriding values

From: Jeff King <peff@peff.net>
Date: Dec 20, 2024, 15:56 UTC
Message-ID: <20241220155610.GD152570@coredump.intra.peff.net>
In-Reply-To: <20241220-b4-pks-git-version-via-environment-v2-0-f1457a5e8c38@pks.im>

On Fri, Dec 20, 2024 at 01:22:44PM +0100, Patrick Steinhardt wrote:

Show 6 quoted lines

> Changes in v2:
> 
>   - Don't strip leading `v`s when `GIT_VERSION` was set explicitly.
>   - Allow setting build info via "config.mak" again.
>   - Wire up build info options for Meson.
>   - Link to v1: https://lore.kernel.org/r/20241219-b4-pks-git-version-via-environment-v1-0-9393af058240@pks.im

Thanks, I confirmed that this fixes the doc-diff issue, and setting values in config.mak works.

I left some small comments on patch 1. Patches 2-4 look good to me, and I'm not qualified to comment on meson patches. ;)

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.