Re: [PATCH] refs: mark invalid refname message for translation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 20, 2024, 15:53 UTC
- Message-ID
- <xmqqzfkqe4g7.fsf@gitster.g>
- In-Reply-To
- <20241220125837.2774153-1-karthik.188@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 11 quoted lines
> The error message produced by `transaction_refname_valid()` changes based
> on whether the update is a ref update or a reflog update, with the use
> of a ternary operator. This breaks translation since the sub-msg is not
> marked for translation. Fix this by setting the entire message using a
> `if {} else {}` block and marking each message for translation.
>
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---
>
> Since the reflog migration topic has been merged to 'next', I am sending this
> as an individual patch which applies on top of 'kn/reflog-migration'. Thanks, that is the most sensible way to fix up a glitch that was discovered too late ;-) Will queue.