Re: [PATCH v3 0/8] refs: add reflog support to `git refs migrate`

From: karthik nayak <karthik.188@gmail.com>
Date: Dec 16, 2024, 14:33 UTC
Message-ID: <CAOLa=ZQHaGO+o=9vda0eA62K1kvdpi0yjm6adxEDhVhn4NFbpA@mail.gmail.com>
In-Reply-To: <xmqq34io8ptl.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Overall, this series is a bit more involved, and I would appreciate it
>> if it receives a bit more scrutiny.
>>
>> The series is based on top of e66fd72e97 (The fourteenth batch,
>> 2024-12-06) with `kn/reftable-writer-log-write-verify` merged in.
>
> t1460.6 does not pass for me.  I noticed it after I merged it to
> 'seen', but it fails standalone as well.
>

Thanks Junio, seems like this passes on GCC and that is what I was using. Sadly, it also passes on older clang version, which is what the CI uses. Unfortunately I assumed that the CI passing [1] should be validation enough. But I can indeed reproduce this locally with clang.

Patrick posted a fix on the list [1] and also discovered one more while we were discussing off the list. I'll send in the next version with both of those included once I validate all the tests once more.

[1]: https://gitlab.com/gitlab-org/git/-/pipelines/1589854339 [2]: https://lore.kernel.org/r/Z1_KzlKc7RBfas4L@pks.im

[snip]