Re: [PATCH] refs: dereference the value of the required pointer

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 19, 2025, 03:54 UTC
Message-ID: <xmqqzf7fw2hd.fsf@gitster.g>
In-Reply-To: <pull.2130.git.git.1766074249443.gitgitgadget@gmail.com>

"AZero13 via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

> From: Greg Funni <gfunni234@gmail.com>
>
> Currently, this always prints yes because required is non-null.
>
> This is the wrong behavior. The boolean must be
> dereferenced.

The line is blamed to f6c5ca38 (refs: add a `optimize_required` field to `struct ref_storage_be`, 2025-11-08); the author CC'ed for an Ack.

Thanks.

Show 33 quoted lines

>
> Signed-off-by: Greg Funni <gfunni234@gmail.com>
> ---
>     refs: dereference the value of the required pointer
>     
>     Currently, this always prints yes because required is non-null.
>     
>     This is the wrong behavior. The boolean must be dereferenced.
>     
>     Signed-off-by: Greg Funni gfunni234@gmail.com
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2130%2FAZero13%2Fref-cache-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2130/AZero13/ref-cache-v1
> Pull-Request: https://github.com/git/git/pull/2130
>
>  refs/debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/refs/debug.c b/refs/debug.c
> index 3e31228c9a..639db0f26e 100644
> --- a/refs/debug.c
> +++ b/refs/debug.c
> @@ -139,7 +139,7 @@ static int debug_optimize_required(struct ref_store *ref_store,
>  	struct debug_ref_store *drefs = (struct debug_ref_store *)ref_store;
>  	int res = drefs->refs->be->optimize_required(drefs->refs, opts, required);
>  	trace_printf_key(&trace_refs, "optimize_required: %s, res: %d\n",
> -			 required ? "yes" : "no", res);
> +			 *required ? "yes" : "no", res);
>  	return res;
>  }
>  
>
> base-commit: c4a0c8845e2426375ad257b6c221a3a7d92ecfda