Re: [PATCH] refs: dereference the value of the required pointer

From: Karthik Nayak <karthik.188@gmail.com>
Date: Dec 25, 2025, 21:23 UTC
Message-ID: <CAOLa=ZQwrdXOocxB1A5TyGYBecQYcM2r2p8ZUZfBiav04cuSGw@mail.gmail.com>
In-Reply-To: <xmqqzf7fw2hd.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> "AZero13 via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>> From: Greg Funni <gfunni234@gmail.com>
>>
>> Currently, this always prints yes because required is non-null.
>>
>> This is the wrong behavior. The boolean must be
>> dereferenced.
>
> The line is blamed to f6c5ca38 (refs: add a `optimize_required`
> field to `struct ref_storage_be`, 2025-11-08); the author CC'ed for
> an Ack.
>
> Thanks.
>

My responses are a bit slow due to being on holiday.

The patch looks good to me, the fix makes sense. Thanks both!