Re: [PATCH 1/2] hook: honor hook.<event>.enabled for the hookdir hook
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 20, 2026, 18:46 UTC
- Message-ID
- <xmqqzew8us4s.fsf@gitster.g>
- In-Reply-To
- <1a7d060fae0decbe7dda63ec4ab57e32e0205df0.1792520353.git.gitgitgadget@gmail.com>
"Thomas Bachem via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 6 quoted lines
> From: Thomas Bachem <mail@thomasbachem.com> > > The documentation added by dcfb5af67e (hook: add hook.<event>.enabled > switch, 2026-04-10) says that with hook.<event>.enabled set to false > "no hooks fire for that event", but only hooks defined in the > configuration are skipped.
It is good to see that the original author and those who helped were CC'ed.
I have a suspicion that the current behavior may be very much deliberate, and the documentation was written too loosely. In other words, the author may have been so excited about their shiny new toy, the configuration-defined hook mechanism, that they wrote as if that were the only kind of hook that existed in the world, even though that is not true.
Let's see what others want to happen.
Thanks.