git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] hook: honor hook.<event>.enabled for the hookdir hook

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 20, 2026, 18:46 UTC
Message-ID
<xmqqzew8us4s.fsf@gitster.g>
In-Reply-To
<1a7d060fae0decbe7dda63ec4ab57e32e0205df0.1792520353.git.gitgitgadget@gmail.com>
"Thomas Bachem via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 6 quoted lines
> From: Thomas Bachem <mail@thomasbachem.com>
>
> The documentation added by dcfb5af67e (hook: add hook.<event>.enabled
> switch, 2026-04-10) says that with hook.<event>.enabled set to false
> "no hooks fire for that event", but only hooks defined in the
> configuration are skipped.

It is good to see that the original author and those who helped were CC'ed.

I have a suspicion that the current behavior may be very much deliberate, and the documentation was written too loosely. In other words, the author may have been so excited about their shiny new toy, the configuration-defined hook mechanism, that they wrote as if that were the only kind of hook that existed in the world, even though that is not true.

Let's see what others want to happen.
Thanks.
Previous: Thomas Bachem via GitGitGadgetNext: Adrian Ratiu
Message 3 of 11 in “Fix two hook configuration bugs”
  1. 0/2 Fix two hook configuration bugsThomas Bachem via GitGitGadget, Oct 20, 2026
  2. 1/2 hook: honor hook.<event>.enabled for the hookdir hookThomas Bachem via GitGitGadget, Oct 20, 2026
  3. Junio C HamanoOct 20, 2026
  4. Adrian RatiuOct 20, 2026
  5. Junio C HamanoOct 21, 2026
  6. Adrian RatiuOct 22, 2026
  7. 2/2 hook: accept .enabled and .parallel given without a valueThomas Bachem via GitGitGadget, Oct 20, 2026
  8. 0/2 Two hook configuration changesThomas Bachem via GitGitGadget, Oct 23, 2026
  9. 1/2 hook: make hook.<event>.enabled cover the hookdir hookThomas Bachem via GitGitGadget, Oct 23, 2026
  10. 2/2 hook: accept .enabled and .parallel given without a valueThomas Bachem via GitGitGadget, Oct 23, 2026
  11. Junio C HamanoOct 23, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.