git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] Two hook configuration changes

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 23, 2026, 17:53 UTC
Message-ID
<xmqqh5ic7174.fsf@gitster.g>
In-Reply-To
<pull.2272.v2.git.1792761542.gitgitgadget@gmail.com>
"Thomas Bachem via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 18 quoted lines
> Two small changes to hook configuration. With the first,
> hook.pre-commit.enabled=false also stops the pre-commit hook in the hooks
> directory. With the second, hook.*.enabled and hook.*.parallel can be given
> without a value, which means true, as for any other boolean.
>
> Changes since v1:
>
>  * The documentation of hook.<event>.enabled now says that it covers
>    configured hooks and the hook in the hooks directory alike. The subject
>    and message of patch 1 present this as a change in behavior rather than a
>    fix (Adrian, Junio).
>
>  * The test that hook.<event>.enabled=false leaves the hooks of other events
>    alone now has a hookdir hook too.
>
> Thomas Bachem (2):
>   hook: make hook.<event>.enabled cover the hookdir hook
>   hook: accept .enabled and .parallel given without a value
Thanks, the range-diff looks good.  Will queue.
Previous: Thomas Bachem via GitGitGadget
Message 11 of 11 in “Fix two hook configuration bugs”
  1. 0/2 Fix two hook configuration bugsThomas Bachem via GitGitGadget, Oct 20, 2026
  2. 1/2 hook: honor hook.<event>.enabled for the hookdir hookThomas Bachem via GitGitGadget, Oct 20, 2026
  3. Junio C HamanoOct 20, 2026
  4. Adrian RatiuOct 20, 2026
  5. Junio C HamanoOct 21, 2026
  6. Adrian RatiuOct 22, 2026
  7. 2/2 hook: accept .enabled and .parallel given without a valueThomas Bachem via GitGitGadget, Oct 20, 2026
  8. 0/2 Two hook configuration changesThomas Bachem via GitGitGadget, Oct 23, 2026
  9. 1/2 hook: make hook.<event>.enabled cover the hookdir hookThomas Bachem via GitGitGadget, Oct 23, 2026
  10. 2/2 hook: accept .enabled and .parallel given without a valueThomas Bachem via GitGitGadget, Oct 23, 2026
  11. Junio C HamanoOct 23, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.