Re: [PATCH v3 0/2] [Outreachy PATCH] archive: remove USE_THE_REPOSITORY_VARIABLE from archival modules
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 10, 2026, 19:17 UTC
- Message-ID
- <xmqqzevgqywt.fsf@gitster.g>
- In-Reply-To
- <pull.2305.v3.git.1794335969.gitgitgadget@gmail.com>
"Srujith A Poojary via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Refactored archive-tar.c, archive-zip.c, archive.c, and supporting files to > use explicit struct repository *repo pointers instead of global repository > variables.
It is not considered good manners to send a new iteration before first finishing the discussion on the reviews you received on your previous iteration. You respond to reviews, saying "I will fix this point", "I think this one is fine as-is because...", and so forth, wait for responses to your response, and eventually come to an agreement with those in the discussion, so both sides know what the next iteration should look like before you start working on it.
Only after finishing all of that do you prepare and send a new iteration.
Thanks.