Re: [PATCH v4] archive: remove USE_THE_REPOSITORY_VARIABLE from archival modules
- From
- Srujith Poojary <poojarysrujith@gmail.com>
- Date
- Nov 11, 2026, 12:24 UTC
- Message-ID
- <CABh_KWg+v7Pme=7n6_MPjxBOVpX9BHbajKB10cCASOo0p1uNKA@mail.gmail.com>
- In-Reply-To
- <CAOLa=ZT7xKFf5_Q5hBfstyeXfTA=TDfzS-Z7mig18rZLgLKefw@mail.gmail.com>
On Wed, Nov 11, 2026 at 4:38 PM Karthik Nayak <karthik.188@gmail.com> wrote:
Show 51 quoted lines
>
> "Srujith A Poojary via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > From: Srujith A Poojary <poojarysrujith@gmail.com>
> >
> > Refactor archive-tar.c and builtin/archive.c to clean up archiver
> > initialization order and header dependencies.
> >
>
> Please read the 'describe-changes' section of the
> Documentation/SubmittingPatches. This message here doesn't explain
> anything.
>
> [snip]
>
> > archive-tar.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/archive-tar.c b/archive-tar.c
> > index a1c66024d4..1b376d048a 100644
> > --- a/archive-tar.c
> > +++ b/archive-tar.c
> > @@ -531,11 +531,15 @@ void init_tar_archiver(void)
> > int i;
> > register_archiver(&tar_archiver);
> >
> > + /* Set built-in defaults first so user config can override them */
> > tar_filter_config("tar.tgz.command", internal_gzip_command, NULL);
> > tar_filter_config("tar.tgz.remote", "true", NULL);
> > tar_filter_config("tar.tar.gz.command", internal_gzip_command, NULL);
> > tar_filter_config("tar.tar.gz.remote", "true", NULL);
> > +
> > + /* Load repository config so user settings override the defaults above */
> > repo_config(the_repository, git_tar_config, NULL);
> > +
> > for (i = 0; i < nr_tar_filters; i++) {
> > /* omit any filters that never had a command configured */
> > if (tar_filters[i]->filter_command)
> >
> > base-commit: 6de20f6092dcf9bdb1c8efe03db4b70c82b423dd
> > --
> > gitgitgadget
>
> So the code only adds two comments? Which isn't what the message
> suggested at all.
>
> Taking a step back and reading your previous commits and messages seems
> like we're talking to an AI model. I'll refrain from reviewing further.
>
> Thanks,
> KarthikHi Karthik, Hi Junio,
Thank you for catching this. You are completely right—the previous commit message described refactoring that was not reflected in the actual diff, which caused a clear mismatch between the message and the code. I apologize for the confusion and for sending automated-sounding responses. As an Outreachy applicant, I am still learning the Git upstream review process and workflow. I have amended the commit message to accurately describe the exact changes in the diff and force-pushed the updated commit.
Best regards, Srujith A Poojary