git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug? diff.submodule=log adds text to commit -v message

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 12, 2013, 22:20 UTC
Message-ID
<xmqqy54tfeje.fsf@gitster.dls.corp.google.com>
In-Reply-To
<5282A90A.4030900@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
Show 17 quoted lines
> Am 12.11.2013 08:46, schrieb Johannes Sixt:
>> Am 11.11.2013 22:29, schrieb Jens Lehmann:
>>> The diff below fixes the problem you describe for me. (But I do not
>>> consider it a worthwhile fix in its current form because a line
>>> starting with "Submodule " might appear in a perfectly normal commit
>>> message, while "diff --git " most probably won't).
>> 
>> And on top of that, "Submodule " originates from a translatable string,
>> doesn't it?
>
> This would also be true for the marker line that Peff proposed:
>
>   # Everything below this line is a diff that will be removed.
>
> But I suspect that would be ok if the marker would be both added
> and searched for in its translated form. Or is it possible that
> the locale changes between those two steps?

If we were introducing a divider line for machine consumption, I do not think it is wise to let that line even translated...

Previous: Jens LehmannNext: Jens Lehmann
Message 9 of 23 in “Bug? diff.submodule=log adds text to commit -v message”
  1. Ari PollakNov 10, 2013
  2. Jens LehmannNov 11, 2013
  3. Ari PollakNov 11, 2013
  4. Jens LehmannNov 11, 2013
  5. Jens LehmannNov 11, 2013
  6. Jeff KingNov 11, 2013
  7. Johannes SixtNov 12, 2013
  8. Jens LehmannNov 12, 2013
  9. Junio C HamanoNov 12, 2013
  10. Jens LehmannNov 13, 2013
  11. Junio C HamanoNov 13, 2013
  12. commit -v: strip diffs and submodule shortlogs from the commit messageJens Lehmann, Nov 16, 2013
  13. Eric SunshineNov 17, 2013
  14. Jeff KingNov 17, 2013
  15. Jeff KingNov 17, 2013
  16. Jens LehmannNov 17, 2013
  17. Junio C HamanoNov 18, 2013
  18. commit -v: strip diffs and submodule shortlogs from the commit messageJens Lehmann, Nov 19, 2013
  19. Junio C HamanoNov 19, 2013
  20. Junio C HamanoNov 19, 2013
  21. Junio C HamanoNov 19, 2013
  22. Junio C HamanoNov 19, 2013
  23. Jens LehmannNov 19, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.