git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 ] commit -v: strip diffs and submodule shortlogs from the commit message

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 19, 2013, 20:34 UTC
Message-ID
<xmqqd2lw871i.fsf@gitster.dls.corp.google.com>
In-Reply-To
<528BB23D.4020001@web.de>
Jens Lehmann <Jens.Lehmann@web.de> writes:
Show 19 quoted lines
> Am 18.11.2013 17:01, schrieb Junio C Hamano:
>> Jeff King <peff@peff.net> writes:
>> 
>>> I found this hard to parse, I think because of the "keeping" (why would
>>> I not keep it?), and because you are talking about lines above and
>>> below. It is not as accurate to say:
>>>
>>>   # ------------------ >8 --------------------
>>>   # Everything below this line will be removed.
>>>
>>> because it is technically the line above that is the cutoff. But I think
>>> the meaning is clear, and it is simpler to parse.
>
> Ok, changed in this version.
>
>> I agree with your rewording suggestion....
>
> Which is what my last version already did :-)  But it didn't mention
> that in the commit message, which it does now).

Oh, another thing. Does this interact with the core.commentChar in any way, and if so how?

Previous: Junio C HamanoNext: Jens Lehmann
Message 22 of 23 in “Bug? diff.submodule=log adds text to commit -v message”
  1. Ari PollakNov 10, 2013
  2. Jens LehmannNov 11, 2013
  3. Ari PollakNov 11, 2013
  4. Jens LehmannNov 11, 2013
  5. Jens LehmannNov 11, 2013
  6. Jeff KingNov 11, 2013
  7. Johannes SixtNov 12, 2013
  8. Jens LehmannNov 12, 2013
  9. Junio C HamanoNov 12, 2013
  10. Jens LehmannNov 13, 2013
  11. Junio C HamanoNov 13, 2013
  12. commit -v: strip diffs and submodule shortlogs from the commit messageJens Lehmann, Nov 16, 2013
  13. Eric SunshineNov 17, 2013
  14. Jeff KingNov 17, 2013
  15. Jeff KingNov 17, 2013
  16. Jens LehmannNov 17, 2013
  17. Junio C HamanoNov 18, 2013
  18. commit -v: strip diffs and submodule shortlogs from the commit messageJens Lehmann, Nov 19, 2013
  19. Junio C HamanoNov 19, 2013
  20. Junio C HamanoNov 19, 2013
  21. Junio C HamanoNov 19, 2013
  22. Junio C HamanoNov 19, 2013
  23. Jens LehmannNov 19, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.