Re: [PATCH] Move test-* to t/helper/ subdirectory

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 27, 2016, 16:15 UTC
Message-ID: <xmqqy47z9geq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160427101833.GA5536@lanh>

Duy Nguyen <pclouds@gmail.com> writes:

> This patch forces bin-wrappers regeneration every time a test program
> is updated. A bit wasteful, but I don't see a better option (which is
> also why I limit this to test programs only).

In other words, when we update the location where the programs that would be eventually installed are created, we'd see the same problem.

I actually wonder if it is a better overall structure to move t/helper/test-foo back to test-foo, while keeping the source file that contains main() for test-foo at t/helper/test-foo.c. Then we do not have to have many copies that are slightly different in bin-wrappers, but they can all be

	exec "${GIT_EXEC_PATH}/$0" "$@"

instead of "bin-wrappers/git-bar" being

	exec "${GIT_EXEC_PATH}/git-bar" "$@"

and "bin-wrappers/test-foo" being

	exec "${GIT_EXEC_PATH}/t/helper/test-foo" "$@"