Re: [PATCH] Move test-* to t/helper/ subdirectory

From: Duy Nguyen <pclouds@gmail.com>
Date: Apr 27, 2016, 00:52 UTC
Message-ID: <CACsJy8A8vbp4-LrxoNX510Nme97EKfu0hBBs-LDRap1Z5=v3rA@mail.gmail.com>
In-Reply-To: <xmqqwpnkc9ca.fsf@gitster.mtv.corp.google.com>

On Wed, Apr 27, 2016 at 5:07 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

> Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:
>
>> This keeps top dir a bit less crowded. And because these programs are
>> for testing purposes, it makes sense that they stay somewhere in t/
>>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> ---
>>  This patch will break any patches that add new test programs.
>>  Luckily, none in 'next' or 'pu' does that. I know lmdb backend adds
>>  test-lmdb-backend, so a manual move and some .gitignore fixup is
>>  required there.
>
> Can you (or somebody else) double check that the resulting Makefile
> gets the build dependencies and exec path right?
>
> I am seeing occasional failure from t0040 when checking out between
> master and pu, and between the branches test-parse-options do change
> behaviour which explains the breakage.

I looked at "make -p" and saw nothing wrong with build rules. A bit concerned about fa8fe28 (Makefile: do not allow gnu make to remove test-*.o files - 2007-08-30) because make info pages say it could leave probably broken .o files when make is interrupted. But that's probably not it.

There is a problem moving between master and next/pu though. bin-wrappers is not regenerated after the move so it could point to the old binaries (in the other place). Not sure how to fix that cleanly, will think of something, maybe, in about 8 hours.

-- 
Duy