Re: [PATCH 05/10] submodule add: send messages to stderr

From: Junio C Hamano <gitster@pobox.com>
Date: May 2, 2016, 23:26 UTC
Message-ID: <xmqqy47soxcf.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1461976845-18228-6-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

Show 9 quoted lines

> Reroute the output of stdout to stderr as it is just informative
> messages, not to be consumed by machines.
>
> This should not regress any scripts that try to parse the
> current output, as the output is already internationalized
> and therefore unstable.
>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---

Sounds sensible.

Show 16 quoted lines

>  git-submodule.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index d689265..f4d500e 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -271,7 +271,7 @@ Use -f if you really want to add it." >&2
>  				echo >&2 "$(eval_gettext "use the '--force' option. If the local git directory is not the correct repo")"
>  				die "$(eval_gettext "or you are unsure what this means choose another name with the '--name' option.")"
>  			else
> -				echo "$(eval_gettext "Reactivating local git directory for submodule '\$sm_name'.")"
> +				echo >&2 "$(eval_gettext "Reactivating local git directory for submodule '\$sm_name'.")"
>  			fi
>  		fi
>  		git submodule--helper clone ${GIT_QUIET:+--quiet} --prefix "$wt_prefix" --path "$sm_path" --name "$sm_name" --url "$realrepo" "$reference" "$depth" || exit