git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 09/10] submodule sync: send messages to stderr

From
Stefan Beller <sbeller@google.com>
Date
Apr 30, 2016, 00:40 UTC
Message-ID
<1461976845-18228-10-git-send-email-sbeller@google.com>
In-Reply-To
<1461976845-18228-1-git-send-email-sbeller@google.com>

Reroute the output of stdout to stderr as it is just informative messages, not to be consumed by machines.

This should not regress any scripts that try to parse the current output, as the output is already internationalized and therefore unstable.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 git-submodule.sh          | 2 +-
 t/t7403-submodule-sync.sh | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index c86c2e5..f075924 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -1095,7 +1095,7 @@ cmd_sync()
 		if git config "submodule.$name.url" >/dev/null 2>/dev/null
 		then
 			displaypath=$(relative_path "$prefix$sm_path")
-			say "$(eval_gettext "Synchronizing submodule url for '\$displaypath'")"
+			say >&2 "$(eval_gettext "Synchronizing submodule url for '\$displaypath'")"
 			git config submodule."$name".url "$super_config_url"
 
 			if test -e "$sm_path"/.git
diff --git a/t/t7403-submodule-sync.sh b/t/t7403-submodule-sync.sh
index 79bc135..93c1dfa 100755
--- a/t/t7403-submodule-sync.sh
+++ b/t/t7403-submodule-sync.sh
@@ -155,7 +155,7 @@ test_expect_success '"git submodule sync" should update submodule URLs - subdire
 		git pull --no-recurse-submodules &&
 		mkdir -p sub &&
 		cd sub &&
-		git submodule sync >../../output
+		git submodule sync 2>../../output
 	) &&
 	grep "\\.\\./submodule" output &&
 	test -d "$(
@@ -186,7 +186,7 @@ test_expect_success '"git submodule sync --recursive" should update all submodul
 		) &&
 		mkdir -p sub &&
 		cd sub &&
-		git submodule sync --recursive >../../output
+		git submodule sync --recursive 2>../../output
 	) &&
 	grep "\\.\\./submodule/sub-submodule" output &&
 	test -d "$(
-- 
2.8.0.32.g71f8beb.dirty
Previous: Stefan BellerNext: Stefan Beller
Message 16 of 20 in “submodule output patches”
  1. 00/10 submodule output patchesStefan Beller, Apr 30, 2016
  2. 01/10 submodule deinit test: fix broken && chain in subshellStefan Beller, Apr 30, 2016
  3. 02/10 submodule deinit: lose requirement for giving '.'Stefan Beller, Apr 30, 2016
  4. 03/10 submodule init: redirect stdout to stderrStefan Beller, Apr 30, 2016
  5. 04/10 shell helpers usage: always send help to stderrStefan Beller, Apr 30, 2016
  6. Junio C HamanoMay 2, 2016
  7. Stefan BellerMay 2, 2016
  8. Junio C HamanoMay 3, 2016
  9. Junio C HamanoMay 3, 2016
  10. 05/10 submodule add: send messages to stderrStefan Beller, Apr 30, 2016
  11. Junio C HamanoMay 2, 2016
  12. 06/10 submodule deinit: send messages to stderrStefan Beller, Apr 30, 2016
  13. Junio C HamanoMay 2, 2016
  14. 07/10 submodule foreach: send messages to stderrStefan Beller, Apr 30, 2016
  15. 08/10 submodule update: send messages to stderrStefan Beller, Apr 30, 2016
  16. 09/10 submodule sync: send messages to stderrStefan Beller, Apr 30, 2016
  17. 10/10 submodule deinit: complain when given a file instead of a submoduleStefan Beller, Apr 30, 2016
  18. Per CederqvistMay 2, 2016
  19. Stefan BellerMay 2, 2016
  20. Stefan BellerMay 2, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.