Re: [PATCH 11/15] diff: ignore submodules excluded by groups

From: Junio C Hamano <gitster@pobox.com>
Date: May 6, 2016, 18:59 UTC
Message-ID: <xmqqy47n2esc.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kY5uDzG8PDLMh5e9afg+S3oTjEjq2aRo+s4ud86UCxZQA@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 14 quoted lines

>> Further suppose that the user needs to view a submodule outside the
>> default group temporarily (imagine: for a day or two), while
>> carrying out some specific task.  Perhaps she is working on the
>> documentation submodule, which is her primary task hence her
>> configuration file specifies it as the default, but needs to see the
>> submodule that houses the implementation to describe the behaviour.
>>
>> So she does "init code-module/"; this has explicit pathspec, so
>> there is no difference between the two.  Now, while reading the code
>> module, she finds a typo in a comment, and wants to fix it.  We will
>> start to see differences.
>
> Another way (3) is to add code-module/ to the "set of interesting
> submodules, i.e. to the default group"

I do not want to force her to do more than "submodule deinit" when she is done with that temporary task that required her to have code-module/ checked out, which is what you are doing with such a change. So that is a non-starter to me.

Show 15 quoted lines

>> The amount of "extra" in the first use case necessary for (1) is
>> greater than the amount of "extra" in the second use case necessary
>> for (2), though.  In addition, in the second use case, (1) makes it
>> easier for the user to miss important changes she made outside the
>> area of her usual attention, while (2) forces her to make a
>> conscious effort to exclude them.  These are the reasons why I have
>> a slight preference for (2) over (1).
>>
>
> That makes sense.
>
> So with (2)
>  * there is no need to modify status, diff, log for the default case and the
>     --recursive \*default" may come later, so the initial series can be smaller.
>  *

I sense a premature "Send" button here ;-)

In any case, I care much more about the "making it harder to miss things outside the usual area of attention" benefit than "the user may have to type less more often" benefit, even though both are slightly in favor between (1) and (2).