Re: [PATCH 07/15] submodule deinit: loose requirement for giving '.'

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 29, 2016, 18:27 UTC
Message-ID: <xmqqtwikxobl.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1461703833-10350-8-git-send-email-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> This is needed later to make a distinction between 'all specified'
> and the default group of submodules.

s/loose/lose/;

Again, this can be separated as an independent preliminary clean-up.

Show 35 quoted lines

>
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  git-submodule.sh           | 5 -----
>  t/t7400-submodule-basic.sh | 1 -
>  2 files changed, 6 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index d7a5e1a..253ad07 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -440,11 +440,6 @@ cmd_deinit()
>  		shift
>  	done
>  
> -	if test $# = 0
> -	then
> -		die "$(eval_gettext "Use '.' if you really want to deinitialize all submodules")"
> -	fi
> -
>  	git submodule--helper list --prefix "$wt_prefix" "$@" |
>  	while read mode sha1 stage sm_path
>  	do
> diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh
> index e9d1d58..ac477b2 100755
> --- a/t/t7400-submodule-basic.sh
> +++ b/t/t7400-submodule-basic.sh
> @@ -932,7 +932,6 @@ test_expect_success 'submodule deinit . deinits all initialized submodules' '
>  	git submodule update --init &&
>  	git config submodule.example.foo bar &&
>  	git config submodule.example2.frotz nitfol &&
> -	test_must_fail git submodule deinit &&
>  	git submodule deinit . >actual &&
>  	test -z "$(git config --get-regexp "submodule\.example\.")" &&
>  	test -z "$(git config --get-regexp "submodule\.example2\.")" &&