Re: What's cooking in git.git (May 2016, #02; Fri, 6)

From: Junio C Hamano <gitster@pobox.com>
Date: May 10, 2016, 07:20 UTC
Message-ID: <xmqqy47iqszk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1605100757410.4092@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 18 quoted lines

> On Fri, 6 May 2016, Junio C Hamano wrote:
>
>> * jc/fsck-nul-in-commit (2016-04-14) 2 commits
>>  - fsck: detect and warn a commit with embedded NUL
>>  - fsck_commit_buffer(): do not special case the last validation
>> 
>>  "git fsck" learned to catch NUL byte in a commit object as
>>  potential error and warn.
>> 
>>  What was the status of this one?  Ready to proceed?
>
> I think this code looks fine. Maybe two comments on the test:
>
>>               test_must_fail git -c fsck.nulInCommit=error fsck 2>warn.1 &&
>>               git fsck 2>warn.2 &&
>>               grep nulInCommit warn.2
>
> 1) warn.1 is not used. Maybe skip that redirection?

Or check it for expected result.  I don't know offhand which is better.

> 2) I was under the impression that we preferred test_i18ngrep over grep...

Only when the strings we are expecting are subject to i18n. I somehow did not think your report() codepath has any i18n/l10n?