Re: What's cooking in git.git (May 2016, #02; Fri, 6)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 13, 2016, 11:52 UTC
Message-ID: <alpine.DEB.2.20.1605131349020.4092@virtualbox>
In-Reply-To: <xmqqy47iqszk.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Tue, 10 May 2016, Junio C Hamano wrote:

Show 8 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > On Fri, 6 May 2016, Junio C Hamano wrote:
> >
> > 2) I was under the impression that we preferred test_i18ngrep over grep...
> 
> Only when the strings we are expecting are subject to i18n.  I
> somehow did not think your report() codepath has any i18n/l10n?

I finally remembered why I thought that test_i18ngrep was to be preferred over grep. For years, Git for Windows carried a patch that introduced a special `cmp` for use with text files, so that differences in the end-of-line markers could be ignored. IIRC we abandoned this when test_i18ncmp learned to perform this trick. Only that it really is test_cmp that learned this trick... so I was wrong.

So please forget what I said about this part of the patch.

Ciao, Dscho