Re: [PATCH v3 04/14] i18n: blame: mark error messages for translation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 15, 2016, 20:14 UTC
- Message-ID
- <xmqqy42sncok.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1473951548-31733-4-git-send-email-vascomalmeida@sapo.pt>
Vasco Almeida <vascomalmeida@sapo.pt> writes:
Show 6 quoted lines
> @@ -2790,7 +2790,7 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
> else {
> o = get_origin(&sb, sb.final, path);
> if (fill_blob_sha1_and_mode(o))
> - die("no such path %s in %s", path, final_commit_name);
> + die(_("no such path %s in %s"), path, final_commit_name);This was missing in the earlier round, which is good to make it translated.
> - die("file %s has only %lu lines", path, lno);
> + die(Q_("file %s has only %lu line",
> + "file %s has only %lu lines",
> + lno), path, lno);Looks good here, too. I would have moved "lno)," at the beginning of the third line to the end of the second line to make it easier to read, but this is OK.