git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 04/14] i18n: blame: mark error messages for translation

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 15, 2016, 20:14 UTC
Message-ID
<xmqqy42sncok.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<1473951548-31733-4-git-send-email-vascomalmeida@sapo.pt>
Vasco Almeida <vascomalmeida@sapo.pt> writes:
Show 6 quoted lines
> @@ -2790,7 +2790,7 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
>  	else {
>  		o = get_origin(&sb, sb.final, path);
>  		if (fill_blob_sha1_and_mode(o))
> -			die("no such path %s in %s", path, final_commit_name);
> +			die(_("no such path %s in %s"), path, final_commit_name);
This was missing in the earlier round, which is good to make it translated.
> -			die("file %s has only %lu lines", path, lno);
> +			die(Q_("file %s has only %lu line",
> +			       "file %s has only %lu lines",
> +			       lno), path, lno);

Looks good here, too. I would have moved "lno)," at the beginning of the third line to the end of the second line to make it easier to read, but this is OK.

Previous: Vasco AlmeidaNext: Vasco Almeida
Message 23 of 34 in “i18n: apply: mark plural string for translation”
  1. 01/13 i18n: apply: mark plural string for translationVasco Almeida, Sep 7, 2016
  2. 03/13 i18n: apply: mark info messages for translationVasco Almeida, Sep 7, 2016
  3. 02/13 i18n: apply: mark error messages for translationVasco Almeida, Sep 7, 2016
  4. 04/13 i18n: blame: mark error messages for translationVasco Almeida, Sep 7, 2016
  5. Jean-Noël AVILASep 10, 2016
  6. Junio C HamanoSep 12, 2016
  7. 05/13 i18n: branch: mark option description for translationVasco Almeida, Sep 7, 2016
  8. 11/13 i18n: receive-pack: mark messages for translationVasco Almeida, Sep 7, 2016
  9. 13/13 i18n: update-index: mark warning for translationVasco Almeida, Sep 7, 2016
  10. 12/13 i18n: show-branch: mark error messages for translationVasco Almeida, Sep 7, 2016
  11. 09/13 i18n: notes: mark error messages for translationVasco Almeida, Sep 7, 2016
  12. 13/13 i18n: update-index: mark warnings for translationVasco Almeida, Sep 7, 2016
  13. 10/13 notes: lowercase first word of error messagesVasco Almeida, Sep 7, 2016
  14. 08/13 i18n: merge-recursive: mark verbose message for translationVasco Almeida, Sep 7, 2016
  15. 06/13 i18n: config: mark error message for translationVasco Almeida, Sep 7, 2016
  16. 07/13 i18n: merge-recursive: mark error messages for translationVasco Almeida, Sep 7, 2016
  17. Junio C HamanoSep 9, 2016
  18. Junio C HamanoSep 8, 2016
  19. 01/14 i18n: apply: mark plural string for translationVasco Almeida, Sep 15, 2016
  20. 02/14 i18n: apply: mark error messages for translationVasco Almeida, Sep 15, 2016
  21. 03/14 i18n: apply: mark info messages for translationVasco Almeida, Sep 15, 2016
  22. 04/14 i18n: blame: mark error messages for translationVasco Almeida, Sep 15, 2016
  23. Junio C HamanoSep 15, 2016
  24. 05/14 i18n: branch: mark option description for translationVasco Almeida, Sep 15, 2016
  25. 06/14 i18n: config: mark error message for translationVasco Almeida, Sep 15, 2016
  26. 07/14 i18n: merge-recursive: mark error messages for translationVasco Almeida, Sep 15, 2016
  27. 08/14 i18n: merge-recursive: mark verbose message for translationVasco Almeida, Sep 15, 2016
  28. 09/14 i18n: notes: mark error messages for translationVasco Almeida, Sep 15, 2016
  29. 11/14 i18n: receive-pack: mark messages for translationVasco Almeida, Sep 15, 2016
  30. 10/14 notes: lowercase first word of error messagesVasco Almeida, Sep 15, 2016
  31. 12/14 i18n: show-branch: mark error messages for translationVasco Almeida, Sep 15, 2016
  32. 14/14 i18n: update-index: mark warnings for translationVasco Almeida, Sep 15, 2016
  33. 13/14 i18n: show-branch: mark plural strings for translationVasco Almeida, Sep 15, 2016
  34. Junio C HamanoSep 15, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.