Re: [PATCH 2/2] name-rev: favor describing with tags and use committer date to tiebreak

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 17, 2017, 05:45 UTC
Message-ID: <xmqqy3w48nif.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <9AE7ADCA-97F9-4857-AC55-76C4BD822C25@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

> A quick bisect indicates that this patch might break 
> t9807-git-p4-submit.sh 8 and 13. I haven't looked into
> it further, yet.

As I do not do P4, help in diagnosing why it breaks is appreciated. If the test script expects a commit, that can be described in two more more ways, is named one way (e.g. named after a branch) and the new "favor tags even if they are unannotated" behaviour breaks its expectation, and the only thing the test _should_ care about is what commit the result is, then clearly the test script needs to be fixed. On the other hand, if git-p4 command internally uses name-rev and it is not prepared to properly handle commits that can be named in more than one way, the problem would be deeper, as it would mean it can misbehave even without the change to name-rev when multiple branches point at the same commit.

Thanks.