Re: [PATCH 0/2] Teach name-rev to pay more attention to lightweight tags

From: Jacob Keller <jacob.keller@gmail.com>
Date: Mar 16, 2017, 10:28 UTC
Message-ID: <CA+P7+xqa4Ku7M5ZjrHNpeetnAguZpjz920L=Q5+7mb2A0rFywQ@mail.gmail.com>
In-Reply-To: <20170315225045.15788-1-gitster@pobox.com>

On Wed, Mar 15, 2017 at 3:50 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Here is a reroll of what I did in
>
>     http://public-inbox.org/git/xmqqd1die00j.fsf@gitster.mtv.corp.google.com/
>
> Junio C Hamano (2):
>   name-rev: refactor logic to see if a new candidate is a better name
>   name-rev: favor describing with tags and use committer date to tiebreak
>
>  builtin/name-rev.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++------
>  t/t4202-log.sh     |  2 +-
>  2 files changed, 57 insertions(+), 8 deletions(-)
>
> --
> 2.12.0-306-g4a9b9b32d4
>

This looks like an improvement to me. It may be that someone comes up with a better definition for is_better_name() but it's definitely much easier to do so now as it's easier to understand what the logic is when it's separated out.

Thanks, Jake