Re: [PATCH 0/3] for-each-ref: add :remote-ref and :remote-name specifiers

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 5, 2017, 01:54 UTC
Message-ID: <xmqqy3oq8ilw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <cover.1506952571.git.johannes.schindelin@gmx.de>

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

> Note: the `%(push:remote-name)` placeholder is only interpolated by the value
> of `branch.<name>.pushRemote`; unlike `git push`, it does not fall back to
> `branch.<name>.remote`. Likewise, `%(push:remote-ref)` interpolates to the
> empty string unless `remote.<nick>.pushRefs` is configured.

I think the reason why I had to spend more time than necessary on the above point during my review on this (otherwise mostly well done) topic was because of this note. It says what it does, but does not say why this behaviour is better than the other obvious alternative.

In a reroll to address the remaining points, please update the log message (not the cover, which won't be in the committed history) to explain why we think this is a better choice than an obvious alternative. Let's help future readers of "git log".

Thanks.