Re: [PATCH v2 2/3] for-each-ref: let upstream/push optionally remote ref name

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 11, 2017, 05:58 UTC
Message-ID: <xmqqvajmmdii.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqvajsx3o0.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
>> Subject: Re: [PATCH v2 2/3] for-each-ref: let upstream/push optionally remote ref name
>
> No verb?  s/optionally/report/ perhaps?

I just noticed that I didn't tweak the copy I have in my tree after sending this message, but now I did s/optionally/& report the/;

I am still puzzled by the hunk below, though.

Show 12 quoted lines

>> @@ -1262,6 +1265,14 @@ static void fill_remote_ref_details(struct used_atom *atom, const char *refname,
>>  			*s = xstrdup(remote);
>>  		else
>>  			*s = "";
>> +	} else if (atom->u.remote_ref.option == RR_REMOTE_REF) {
>> +		int explicit, for_push = starts_with(atom->name, "push");
>
> Hmph, the previous step got rid of starts_with() rather nicely by
> introducing atom->u.remote_ref.push bit; can't we do the same in
> this step?
>
> Other than that, looks nicer.

Thanks.