Re: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 12, 2018, 23:27 UTC
Message-ID: <xmqqy3l2ves2.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <008f01d38bfa$7eba9bc0$7c2fd340$@nexbridge.com>

"Randall S. Becker" <rsbecker@nexbridge.com> writes:

> Sadly, fixing the "except" thing causes the test to break now.

That is exactly what I wanted to say. If you want to "fix" it, you'd need to figure out what the author of the "except" thing wanted to test, adjust the args given to test-config (it cannot be the same as the test-config invocation of the previous test), and then fix the typo s/except/expect/. Changing the typo alone *will* of course make the test fail, because then the file with the corrected name, i.e. "expect", has bogus lines that does not match how the current invocation of "test-config" command is expected to output.

Show 17 quoted lines

> sense of the intent of this, unless the test is to find unmatching keys and
> it really does mean "except"
> --- expect      2018-01-12 23:03:41 +0000
> +++ actual      2018-01-12 23:03:41 +0000
> @@ -1,5 +1 @@
> -sam
> -bat
>  hask
> -lama
> -ball
>
> [case]
> baz = lama
> [my]
> new = silk
> [case]
> baz = ball