Re: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404

From: Tanay Abhra <tanayabh@gmail.com>
Date: Jan 13, 2018, 02:51 UTC
Message-ID: <CAEc54XAP0jFuD4J_XUZOuHEBZ+6PceEQbpm7HJEtRt4NS7Lf2A@mail.gmail.com>
In-Reply-To: <xmqqy3l2ves2.fsf@gitster.mtv.corp.google.com>

On Fri, Jan 12, 2018 at 5:27 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

>
> "Randall S. Becker" <rsbecker@nexbridge.com> writes:
>
> > Sadly, fixing the "except" thing causes the test to break now.
>
> That is exactly what I wanted to say.  If you want to "fix" it,
> you'd need to figure out what the author of the "except" thing
> wanted to test, adjust the args given to test-config (it cannot be
> the same as the test-config invocation of the previous test), and
> then fix the typo s/except/expect/.  Changing the typo alone *will*
> of course make the test fail, because then the file with the
> corrected name, i.e. "expect", has bogus lines that does not match
> how the current invocation of "test-config" command is expected to
> output.

Hi Guys,

I was the original author of the test, I am sorry about the typo.

I will submit a patch fixing the test. The fix can be checked at https://github.com/git/git/pull/451.

'configset_get_value' will be changed to 'configset_get_value_multi' since the test expects a list of values instead of a single value.

Thanks, Tanay Abhra