Re: [PATCH] add a script to diff rendered documentation

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 6, 2018, 18:25 UTC
Message-ID: <xmqqy3djnyik.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180806173720.GA5508@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> +while test $# -gt 0
> +do
> +	case "$1" in
> +	-j)
> +		parallel=${1#-j} ;;

This is curious.  Did you mean "-j*)" on the line above this one?

Show 12 quoted lines

> +	-f)
> +		force=t ;;
> +	--)
> +		shift; break ;;
> +	*)
> +		usage ;;
> +	esac
> +	shift
> +done
> +
> +if test -z "$parallel"
> +then

Then "script -j" (no explicit number) would get here and autodetect. Running the script without any "-j" would also get an empty parallel and come here.

So "script -j1" would be how a user would say "I want to use exactly one process, not any parallelism", which makes sense.

Show 6 quoted lines

> +	parallel=$(getconf _NPROCESSORS_ONLN 2>/dev/null)
> +	if test $? != 0 || test -z "$parallel"
> +	then
> +		parallel=1
> +	fi
> +fi