Re: [PATCH] add a script to diff rendered documentation

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 3, 2018, 21:44 UTC
Message-ID: <CAPig+cRKPdYa7-8YB=rV3jJDe47mgB4xwbeWu4a4JQhx9r2h3Q@mail.gmail.com>
In-Reply-To: <20180803213819.GA4650@sigill.intra.peff.net>

On Fri, Aug 3, 2018 at 5:38 PM Jeff King <peff@peff.net> wrote:

Show 8 quoted lines

> On Fri, Aug 03, 2018 at 05:33:17PM -0400, Eric Sunshine wrote:
> I suppose so. Frankly I only added that line to appease git-sh-options
> anyway.
> > Should "j" and "f" be "-j" and "-f", respectively?
> No, they're input to "rev-parse --parseopt".
> > There doesn't seem to a usage() function defined anywhere (and
> > OPTIONS_SPEC doesn't seem to be used).
> It's git-sh-setup automagic. Try "./doc-diff --foo"

Ah yes, I saw but then forgot that 'git-sh-setup' was sourced.

Show 6 quoted lines

> > > +# We'll do both builds in a single worktree, which lets make reuse
> > > +# results that don't differ between the two trees.
> >
> > "which lets make reuse"?
>
> As in, lets the tool "make" reuse results...

Okay, I was confused by "make" being a verb, and thought you had made a last-minute edit, rewriting "which makes it possible to reuse...", and intending to say instead "which lets us reuse...". Had it been formatted "which lets 'make' reuse...", I'd probably have read it correctly. Not worth a re-roll.