Re: [PATCH v3 0/4] multi-pack-index: fix verify on large repos

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 22, 2019, 05:37 UTC
Message-ID: <xmqqy357pizb.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <pull.166.v3.git.gitgitgadget@gmail.com>

"Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 13 quoted lines

> Teach "multi-pack-index verify" to handle cases where the number of
> packfiles exceeds the open file handle limit.
>
> The first commit fixes a problem that prevented the LRU-style
> close_one_pack() mechanism from working which caused midx verify to run out
> of file descriptors.
>
> The second commit teaches midx verify to sort the set of objects to verify
> by packfile rather than verifying them in OID order. This eliminates the
> need to have more than one packfile/idx open at the same time.
>
> With the second commit, runtime on 3600 packfiles went from 12 minutes to 25
> seconds.

These reference to the first and second commit might have become stale across interations, but logically it makes sense---the first point is about correctness (i.e. do not die by running out of fds) and the second one is about usable-performance.

But in this round (possibly in the previous one, too?) the "group objects by packfile" one addresses both points?