git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 2/4] trace2:data: add trace2 data to midx

From
JGJeff Hostetler via GitGitGadget <gitgitgadget@gmail.com>
Date
Mar 19, 2019, 14:37 UTC
Message-ID
<11c88845e7c68990415e3f5d42227ce83a9f8d67.1553006268.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.166.v2.git.gitgitgadget@gmail.com>
From: Jeff Hostetler <jeffhost@microsoft.com>

Log multi-pack-index command mode. Log number of objects and packfiles in the midx.

Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
---
 builtin/multi-pack-index.c | 3 +++
 midx.c                     | 4 ++++
 2 files changed, 7 insertions(+)
diff --git a/builtin/multi-pack-index.c b/builtin/multi-pack-index.c
index fca70f8e4f..ae6e476ad5 100644
--- a/builtin/multi-pack-index.c
+++ b/builtin/multi-pack-index.c
@@ -3,6 +3,7 @@
 #include "config.h"
 #include "parse-options.h"
 #include "midx.h"
+#include "trace2.h"
 
 static char const * const builtin_multi_pack_index_usage[] = {
 	N_("git multi-pack-index [--object-dir=<dir>] (write|verify)"),
@@ -40,6 +41,8 @@ int cmd_multi_pack_index(int argc, const char **argv,
 		return 1;
 	}
 
+	trace2_cmd_mode(argv[0]);
+
 	if (!strcmp(argv[0], "write"))
 		return write_midx_file(opts.object_dir);
 	if (!strcmp(argv[0], "verify"))
diff --git a/midx.c b/midx.c
index 8a505fd423..24141a7c62 100644
--- a/midx.c
+++ b/midx.c
@@ -8,6 +8,7 @@
 #include "sha1-lookup.h"
 #include "midx.h"
 #include "progress.h"
+#include "trace2.h"
 
 #define MIDX_SIGNATURE 0x4d494458 /* "MIDX" */
 #define MIDX_VERSION 1
@@ -164,6 +165,9 @@ struct multi_pack_index *load_multi_pack_index(const char *object_dir, int local
 			      m->pack_names[i]);
 	}
 
+	trace2_data_intmax("midx", the_repository, "load/num_packs", m->num_packs);
+	trace2_data_intmax("midx", the_repository, "load/num_objects", m->num_objects);
+
 	return m;
 
 cleanup_fail:
-- 
gitgitgadget
Previous: Jeff HostetlerNext: Jeff Hostetler via GitGitGadget
Message 18 of 26 in “multi-pack-index: fix verify on large repos”
  1. 0/3 multi-pack-index: fix verify on large reposJeff Hostetler via GitGitGadget, Mar 18, 2019
  2. 1/3 midx: verify: add midx packfiles to the packed_git listJeff Hostetler via GitGitGadget, Mar 18, 2019
  3. 3/3 trace2:data: add trace2 data to midxJeff Hostetler via GitGitGadget, Mar 18, 2019
  4. 2/3 midx: verify: group objects by packfile to speed up object verificationJeff Hostetler via GitGitGadget, Mar 18, 2019
  5. Ævar Arnfjörð BjarmasonMar 18, 2019
  6. Jeff HostetlerMar 18, 2019
  7. Ævar Arnfjörð BjarmasonMar 18, 2019
  8. Junio C HamanoMar 19, 2019
  9. Jeff HostetlerMar 19, 2019
  10. Ævar Arnfjörð BjarmasonMar 19, 2019
  11. 0/4 multi-pack-index: fix verify on large reposJeff Hostetler via GitGitGadget, Mar 19, 2019
  12. 1/4 progress: add sparse mode to force 100% complete messageJeff Hostetler via GitGitGadget, Mar 19, 2019
  13. Eric SunshineMar 19, 2019
  14. Jeff HostetlerMar 19, 2019
  15. Eric SunshineMar 19, 2019
  16. 3/4 midx: verify: add midx packfiles to the packed_git listJeff Hostetler via GitGitGadget, Mar 19, 2019
  17. Jeff HostetlerMar 19, 2019
  18. 2/4 trace2:data: add trace2 data to midxJeff Hostetler via GitGitGadget, Mar 19, 2019
  19. 4/4 midx: verify: group objects by packfile to speed up object verificationJeff Hostetler via GitGitGadget, Mar 19, 2019
  20. 0/4 multi-pack-index: fix verify on large reposJeff Hostetler via GitGitGadget, Mar 21, 2019
  21. 2/4 trace2:data: add trace2 data to midxJeff Hostetler via GitGitGadget, Mar 21, 2019
  22. 3/4 midx: add progress indicators in multi-pack-index verifyJeff Hostetler via GitGitGadget, Mar 21, 2019
  23. 1/4 progress: add sparse mode to force 100% complete messageJeff Hostetler via GitGitGadget, Mar 21, 2019
  24. 4/4 midx: during verify group objects by packfile to speed verificationJeff Hostetler via GitGitGadget, Mar 21, 2019
  25. Junio C HamanoMar 22, 2019
  26. Jeff HostetlerMar 25, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.