Re: [PATCH v5] MyFirstContribution: add avenues for getting help

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 24, 2020, 21:11 UTC
Message-ID: <xmqqy2twy2yw.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20200124205025.GA140846@google.com>

Emily Shaffer <emilyshaffer@google.com> writes:

Show 13 quoted lines

> On Fri, Jan 24, 2020 at 12:35:28PM -0800, Junio C Hamano wrote:
>> emilyshaffer@google.com writes:
>> 
>> > From: Emily Shaffer <emilyshaffer@google.com>
>> 
>> Hmm, unlike folks who use GGG, your From: address seem almost usable
>> without having to waste two extra lines (which matters when one has
>> to review many patches a day).
>
> Blame an unhealthy appreciation for being able to write emails in Vim.
>
> I generate patches with 'git format-patch' - what's the unusable part of
> "almost" usable here?

Compare your message I am responding here, with your message with the patch in it.

This one has a perfectly usable "From:" address,

    From:   Emily Shaffer <emilyshaffer@google.com>

while the patch e-mail has

    From:   emilyshaffer@google.com

which cannot be quite usable as the author identity.