Re: pw/add-p-allowed-options-fix, was Re: What's cooking in git.git (Aug 2020, #06; Mon, 24)

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 25, 2020, 15:46 UTC
Message-ID: <xmqqy2m220ft.fsf@gitster.c.googlers.com>
In-Reply-To: <nycvar.QRO.7.76.6.2008251056290.56@tvgsbejvaqbjf.bet>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 12 quoted lines

> On Mon, 24 Aug 2020, Junio C Hamano wrote:
>
>> * pw/add-p-allowed-options-fix (2020-08-17) 2 commits
>>  - add -p: fix checking of user input
>>  - add -p: use ALLOC_GROW_BY instead of ALLOW_GROW
>>
>>  "git add -p" update.
>>
>>  Will merge to 'next'.
>
> I thought the consensus was to untangle the refactoring in the second
> patch by first fixing the `e` case, and _then_ refactoring?

Not really. My take on it is that everybody would agree that the split would be to "fix 'e' without introducing the code structure change" then to "change the code structure to make the bug impossible", _IF_ we were to split the "fix" part into two. I do not think anybody agreed to anything beyond that, and I am leaning toward keeping the "let's change the code structure to make such a bug impossible to introduce---oops, as a side effect we already fixed the 'e' bug", which, as you say, is more than good enough.

> With Phillip being offline for a couple days, however, I think we can just
> go forward with the patches as-are. They are in "good enough" a shape.

Thanks.