git/list[1] front-page[2] threads[3] people[4] search[5] about
 

pw/add-p-allowed-options-fix, was Re: What's cooking in git.git (Aug 2020, #06; Mon, 24)

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 25, 2020, 08:58 UTC
Message-ID
<nycvar.QRO.7.76.6.2008251056290.56@tvgsbejvaqbjf.bet>
In-Reply-To
<xmqq7dtn3785.fsf@gitster.c.googlers.com>
Hi Junio,
On Mon, 24 Aug 2020, Junio C Hamano wrote:
Show 7 quoted lines
> * pw/add-p-allowed-options-fix (2020-08-17) 2 commits
>  - add -p: fix checking of user input
>  - add -p: use ALLOC_GROW_BY instead of ALLOW_GROW
>
>  "git add -p" update.
>
>  Will merge to 'next'.

I thought the consensus was to untangle the refactoring in the second patch by first fixing the `e` case, and _then_ refactoring?

With Phillip being offline for a couple days, however, I think we can just go forward with the patches as-are. They are in "good enough" a shape.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 4 in “What's cooking in git.git (Aug 2020, #06; Mon, 24)”
  1. Junio C HamanoAug 25, 2020
  2. pw/add-p-allowed-options-fix, was Re: What's cooking in git.git (Aug 2020, #06; Mon, 24)Johannes Schindelin, Aug 25, 2020
  3. Junio C HamanoAug 25, 2020
  4. Emily ShafferAug 25, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.