Re: [PATCH 03/10] tests: start moving to a different default main branch name

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 21, 2020, 22:22 UTC
Message-ID: <xmqqy2jz43tm.fsf@gitster.c.googlers.com>
In-Reply-To: <d9469202c2dda238882150452fac1aa7fc7fbfec.1603135902.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 12 quoted lines

> Note: the `GIT_TEST_DEFAULT_MAIN_BRANCH_NAME` is _not_ intended to be
> used manually; many tests require a specific main branch name and cannot
> simply work with another one. This `GIT_TEST_*` variable is meant purely
> for the transitional period while the entire test suite is converted to
> use `main` as the initial branch name by default.
>
> We also introduce the `PREPARE_FOR_MAIN_BRANCH` prereq that determines
> whether the default main branch name is `main`, and adjust a couple of
> test functions to use it. This prereq will be used to temporarily
> disable a couple test cases to allow for adjusting the test script
> incrementally. Once an entire test is adjusted, we will adjust the test
> so that it is run with `GIT_TEST_DEFAULT_MAIN_BRANCH_NAME=main`.

Good transition plan. The name of the environment variable itself serves as markers that remind us where we need to update once the conversion is done, so there is no need to leave NEEDSWORK comment, either.

Nicely done.